[pca] patchdiag.xref changes broken for 2 days.

[Martin Paul]

Am 21.02.2013 16:38, schrieb Brookins, Neil (Philadelphia):
> I've been closely watching the daily changes in the patchdiag.xref in
> the past 2 weeks. I've found a serious problem that will result in
> PCA not applying patches that should be applied if certain versions
> of patchdiag.xref are used.

Confirmed. Thanks for noticing this and especially the amount of details 
you provided, this helped a lot when looking at the issue.

I've put a fix into the development release of PCA - you can try that 
with the xref file "AS OF Feb/18/13". Comparing output of "pca --minimal 
missingr" between the stable and development releases of PCA, you'll 
notice that the fixed version will now show the last recommended 
revision of the Java patches.

> The solution to this problem is to keep the older Java patch listed
> as recommended in the patchdiag.xref until the new patch is added to
> the same file.

Actually, Oracle does that. In xref "AS OF Feb/18/13", they add a new 
revision of 118666 (42), which is marked S but not R. The previous 
revision (41) is marked O (obsolete), but keeps the R flag. With 
"--minimal", PCA is supposed to ignore the O flag on rev. 41 and use 
that. The problem was that there are two other revisions of 118666 in 
xref, 19 and 34, and both are marked R/S/O as well. No idea why, and I 
really think that these should be removed by Oracle (the Java patches 
were the only ones I found with that pattern). The bug in PCA was that 
it used the first of these revisions (19) and not the last (41). That's 
what I've fixed now.

Thanks again for the report,
Martin.