[pca] pkgchk error: too many pathnames in list

[Martin Paul]

Laurent,

> not sure this is a PCA error, it's a funny error, never seen it before.

As soon as pkgchk is involved, you might expect everything - it's one of 
the most braindead commands I've seen :)

Anyway, I tried "pca --debug --safe --pretend 119548-11" with the same 
version of pca as you had, and couldn't reproduce it - it worked fine, 
although it was interesting that it showed 830 as the number of files to 
check, while you had 819.

So we must have different versions of 119548-11.zip. The copy on my 
local caching proxy was from Oct 07, so I downloaded it from SunSolve 
again, and indeed, I got a different file from Nov 07. Sun has modified 
the README, but kept the same patch revision - not nice.

pca reads the "Files included with this patch" section of the README to 
create the list of files to feed to pkgchk. If a file is removed by a 
patch, it usually reads like that in the README:

   /usr/bin/gaim (deleted)

Now in the new version of the README it reads:

   /usr/bin/gaim <deleted>

pca removes \s+\(deleted\) from each line as this would confuse pkgchk. 
In the case of the new README file, the <deleted> string wasn't removed, 
which in turn confused pkgchk because it doesn't accept more than 1024 
files in one run (it got "/usr/bin/gaim" and "<deleted>" as two files).

The fix is of course to adapt pca to remove <deleted> as well. I had 
another look at my collection of ca. 4000 patch README files, and found 
a handful of other troublesome candidates:

   /usr/lib/adb/root_hub          (deleted file)
   /usr/lib/AdobeReader/doc/acroread/README(deleted)

All of these are fixed in the current development release of pca now.

This definitely earns a place on the list of the more interesting bugs 
in pca :)

Martin.